OceanSlim/dwm-app
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Redo iFrames with jinja templating #2

New Issue
Closed
opened 2024-02-02 20:50:58 +00:00 by OceanSlim · 4 comments
OceanSlim commented 2024-02-02 20:50:58 +00:00
Owner
Copy Link

The iFrames are clunky, hard to style, harder to link javascript to the other templates. Jinja blueprint tempalting should be used instead of this approach

The iFrames are clunky, hard to style, harder to link javascript to the other templates. Jinja blueprint tempalting should be used instead of this approach
OceanSlim commented 2024-02-04 20:30:22 +00:00
Author
Owner
Copy Link

I've worked on this but Only the basic layout is implemented. Right now the footer isn't rendered with a template anymore it's just in the app.html.

I think I can even go without the app html or the footer can be in the layout but only if I redo the rest of the components to be rendered on a template and make more blocks for those things. As it stands if I put the footer in the layout ALL components get the footer.

The problem is the breeds and stats are still not components, they are still shown with iFrames. So there is a need for an app.html that loads and shows them

I wonder if I can make the stats and breeds into templates themselves
They are formatted properly already :)

I've worked on this but Only the basic layout is implemented. Right now the footer isn't rendered with a template anymore it's just in the app.html. I think I can even go without the app html or the footer can be in the layout but only if I redo the rest of the components to be rendered on a template and make more blocks for those things. As it stands if I put the footer in the layout ALL components get the footer. The problem is the breeds and stats are still not components, they are still shown with iFrames. So there is a need for an app.html that loads and shows them ~~I wonder if I can make the stats and breeds into templates themselves~~ They are formatted properly already :)
OceanSlim commented 2024-02-05 13:28:19 +00:00
Author
Owner
Copy Link

i need to extend the other body parts from app to .layout and rename .layout to app and change the render template again.

ie I need components for the header, footer, dropdowns and iFrames. They should extend to what's currently .layout.html

i need to extend the other body parts from app to .layout and rename .layout to app and change the render template again. ie I need components for the header, footer, dropdowns and iFrames. They should extend to what's currently .layout.html
OceanSlim commented 2024-02-05 13:57:15 +00:00
Author
Owner
Copy Link

Turns out these need their own render templates and routes as well... Which I would still be displaying with an iFrame. Still unsure if iFrame is the correct route for this...

Turns out these need their own render templates and routes as well... Which I would still be displaying with an iFrame. Still unsure if iFrame is the correct route for this...
OceanSlim commented 2024-02-05 17:06:34 +00:00
Author
Owner
Copy Link

For now I will keep using iframes to show the individual pages on the root screen. block templating has been implemented, and it's time to close this. api and app.py needs better structure.

For now I will keep using iframes to show the individual pages on the root screen. block templating has been implemented, and it's time to close this. api and app.py needs better structure.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: OceanSlim/dwm-app#2
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?